Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Implementation of non QML launcher #443

Merged
merged 31 commits into from
Aug 17, 2020
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 15, 2020

Changes

  • Added new tool "launcher" to pype.tools which is not QML base
    • based on BigRoy's launcher draft
  • Launcher's context is out of avalon.io.Session so we don't have to care about unexpected context changes
  • Launching of application should be the same as from Ftrack (except triggering timer)
    • extracted launch_application function from ftrack to pype.lib

TODOs

  • Action launch error handling
  • Trigger timer on app launch
🏴 this depends on
pype-config ynput/pype-config#75
avalon-core ynput/avalon-core#177

image

Note

I think we can remove avalon-launcher repo.

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Small comments we discussed.

  1. The button on the bottom right crashes the launcher.
  2. Grouping of applications should be a bit more dynamic to to prevent group from showing if only one group member is available on the project.

@mkolar mkolar added this to the 2.12 milestone Aug 17, 2020
@mkolar mkolar merged commit 68deecc into 2.x/develop Aug 17, 2020
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Sep 9, 2020
@mkolar mkolar deleted the draft/no_qml_launhcer branch September 9, 2020 16:15
@BigRoy
Copy link
Collaborator

BigRoy commented Sep 9, 2020

Nice to see this being adopted by pype. Hope it's usable on your end. :) Any clients using this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants