Better preservation of input file precision through add_pars and apply_mults #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 17, 2024 20:18
…h add_pars and apply mult processes.
|
actually might help with #490 |
Merged
jtwhite79
reviewed
Apr 18, 2024
| try: | ||
| fmt = df_mf.fmt.iloc[0] | ||
| except AttributeError: | ||
| fmt = "%15.6E" |
There was a problem hiding this comment.
I guess we need to keep the 15-6 for old school modflow/mt3d?
There was a problem hiding this comment.
I think with PstFrom it should be ok. The detect 'should' get the right format. We need to is fall-back for the old pstfromflopy method which I don't think stores a 'fmt' (and I didn't fancy opening that box!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should result in less precision noise in workflows