Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: serve 404 page locally #160

Merged
merged 1 commit into from
Mar 28, 2024
Merged

feat: serve 404 page locally #160

merged 1 commit into from
Mar 28, 2024

Conversation

miketheman
Copy link
Member

Resolves #159

@miketheman
feat: serve 404 page locally
c1de8a6 
Resolves pypi#159

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman added the enhancement New feature or request label Mar 27, 2024
@miketheman miketheman requested a review from di March 27, 2024 20:51
@miketheman
Copy link
Member Author

miketheman commented Mar 27, 2024 •
edited
Loading

Ideally, we'd implement this via @app.errorhandler(404)... semantics, but this was the easiest path to solve my issue, and I didn't know the other extent of the next guard clause.

@di di merged commit d645a31 into pypi:main Mar 28, 2024
2 checks passed
@miketheman miketheman deleted the miketheman/159-serve-404 branch March 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serve 404 from Inspector instead of pypi.org
2 participants
@miketheman @di