This repository has been archived by the owner on May 30, 2020. It is now read-only.
Resurrect some tests #535
Closed
Resurrect some tests #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpacer
reviewed
Oct 6, 2016
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| def main(argv): | |||
| if len(argv) != 3: | |||
| print "Usage: apache_count.py configfile logfile" | |||
| print("Usage: apache_count.py configfile logfile") | |||
There was a problem hiding this comment.
How is this working without from __future__ import print_function?
There was a problem hiding this comment.
Oh, it prints a 1-tuple. But that's just because I forgot to commit the from __future__ ... which should be fixed now.
This resurrect (and skip) some tests mostly in the hope that when minimal modification are made to the code base they can be unit tested.
Carreau
force-pushed
the
resurect-unit-tests
branch
from
7e938f1
to
dbc1c3e
Compare
takluyver
approved these changes
Nov 17, 2016
| @@ -99,6 +100,7 @@ def _test_useragent(self): | |||
| self.assertEquals(logs[45]['useragent'], | |||
| 'Python-urllib/2.5 setuptools/0.6c7') | |||
|
|
|||
| @pytest.mark.skip(reason="No clue how this one is supposed to work") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrect (and skip) some tests mostly in the hope that when
minimal modification are made to the code base they can be unit tested.
This will allow @michaelpacer to write tests for #506
Also if you can enable travis-ci :-) Unless you prefer something like CircleCI....