Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New serial causing bandersnatch to generate no link Simple HTML files #5331

Closed
cooperlees opened this issue Jan 23, 2019 · 6 comments
Closed

New serial causing bandersnatch to generate no link Simple HTML files #5331

cooperlees opened this issue Jan 23, 2019 · 6 comments

Comments

@cooperlees
Copy link
Contributor

Describe the bug
I can not see evidence of a new black release today but for some reason 3 of my production bandersnatch mirrors generated ano link index.html. Example:

<!DOCTYPE html>
<html>
  <head>
    <title>Links for black</title>
  </head>
  <body>
    <h1>Links for black</h1>

  </body>
</html>
  • Is there somewhere I can find out why black got a new serial and thus bandersnatch wanted to regenerate the Simple HTML?
  • Bandersnatch logging showed no errors and that everything worked as expected

If this is just an internal error or a known problem please just link me to that and we can close this :).

Expected behavior
Only generate a new serial on new versions. (I could be wrong here)

To Reproduce
Not sure here - As asked above, is there a log somewhere to see why a new serial was generated? Or some datasource I / the general public have access to?

  • I could run a new bandersnatch instance with 3.1.1 and see if I get a blank simple index.html on my laptop using the whitelist feature to only mirror black if you feel that could be nice to see.

My Platform
OS: CentOS
Client = Bandersnatch 3.1.1

Additional context
Have opened pypa/bandersnatch#140 as this is probably a bandersnatch issue.
@di
Copy link
Member

di commented Jan 23, 2019

Can confirm that there is not a new release of black, but there were some changes to the roles for owners of that project today. This would result in a cache purge across any project-specific pages, so it seems likely that this caused the new serial, but it's not clear to me if it should have or not.

@ewdurbin
Copy link
Member

Also confirming that these changes occurred, and that they indeed each lead to an increment of the serial.

Journal:

screen shot 2019-01-23 at 2 28 08 pm

screen shot 2019-01-23 at 2 29 52 pm

The internal bandersnatch mirror is handling this fine, so I do believe it's a potential regression in bandersnatch.

It's also possible that some CDN purging issues we're seeing at the moment may be a compounding factor.

@ewdurbin
Copy link
Member

For reference, internal PyPI bandersnatch is running 2.2.1

@cooperlees
Copy link
Contributor Author

Cheers for the info @ewdurbin - I'll try repro on my laptop this afternoon with bandersnatch trunk.

@cooperlees
Copy link
Contributor Author

cooperlees commented Jan 24, 2019 •
edited
Loading

Making the CI job try and download black and not remove the temp repo on the filesystem I can repro on my laptop. Will dig in and debug bandersnatch.
Diff to trunk: https://pastebin.com/pDDpYH7a

Will close this if I can make a suitable fix in bandersnatch code or submit a PR to Warehouse.

@cooperlees
Copy link
Contributor Author

cooperlees commented Jan 25, 2019 •
edited
Loading

Root caused - Loading all the bandersnatch plugins by default creates unexpected implicit behavior. Turned that off. PR up. Can close here.
pypa/bandersnatch#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@di @ewdurbin @cooperlees