Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bandersnatch generated a no link black/index.html "simple api" file this morning #140

Closed
cooperlees opened this issue Jan 23, 2019 · 2 comments
Closed

bandersnatch generated a no link black/index.html "simple api" file this morning #140

cooperlees opened this issue Jan 23, 2019 · 2 comments
Assignees
@cooperlees
Labels
bug Something isn't working

Comments

@cooperlees
Copy link
Contributor

All 3 of my internal production mirrors this morning around 7:10-7:40am PST USA time (15:10-15:40 UTC) received a new serial for black (4731664) and attempted to sync black. No errors were reported in the bandersnatch logs.

[2019-01-23 07:37:00,407] INFO: Syncing package: black (serial 4731664) (package.py:101)
[2019-01-23 07:37:00,474] INFO: Storing index page: black (package.py:231)

All the package files remained (as expected and bandersnatch does not delete package files (sdists, wheels etc.) but bandersnatch generated a black index.html:

<!DOCTYPE html>
<html>
  <head>
    <title>Links for black</title>
  </head>
  <body>
    <h1>Links for black</h1>

  </body>
</html>

From a spot check it ONLY seems to have effected black. Will log a job with Warehouse to see if they have any thoughts on why the serial as changed as there is no new version to https://pypi.org/project/black/

Can any other bandersnatch users out there let me know if they too got an empty black index.html?

Workaround

wget https://pypi.org/simple/black
mv black index.html
sed -i 's/files\.pythonhosted\.org/your.mirror.awesome/g'
scp index.html your.pypi.mirror:/srv/pypi/web/simple/{b}/black/
@cooperlees cooperlees added the bug Something isn't working label Jan 23, 2019
@cooperlees cooperlees self-assigned this Jan 23, 2019
@cooperlees cooperlees mentioned this issue Jan 23, 2019
Closed
@cooperlees
Copy link
Contributor Author

Can repro on Github trunk manually running integration test with the following diff to enforce black to download: https://pastebin.com/pDDpYH7a

Will look into a fix now.

cooperlees added a commit that referenced this issue Jan 25, 2019
@cooperlees
Fix turning on all plugins by default
a49d316 
- Turning on all plugins by default is misleading and causes unexpected issues
- `black` project has all it's versions as beta, so we were filtering them by default and it clobbered my 3 production mirrors Simple API for `black`
- We now have all plugins off unless explicitly configuring all or the plugins name

Fixes #140

Testing:
- Fix all unit tests
- Edit Integration test to include black
- Manually run Integration with all plugins enabled - See CI fail
- Manually run with ONLY whitelist_project enabled and see it work as expected
@cooperlees cooperlees mentioned this issue Jan 25, 2019
Merged
cooperlees added a commit that referenced this issue Jan 25, 2019
@cooperlees
Fix turning on all plugins by default (#142)
98e4f16 
- Turning on all plugins by default is misleading and causes unexpected issues
- `black` project has all it's versions as beta, so we were filtering them by default and it clobbered my 3 production mirrors Simple API for `black`
- We now have all plugins off unless explicitly configuring all or the plugins name

Fixes #140

Testing:
- Fix all unit tests
- Edit Integration test to include black
- Manually run Integration with all plugins enabled - See CI fail
- Manually run with ONLY whitelist_project enabled and see it work as expected
@cooperlees
Copy link
Contributor Author

Fix merged. Will release a fixed versions today hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooperlees cooperlees

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cooperlees