Invalidate existing sessions for a given User when User.password is changed #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trigger implementation is _best_ since it ensures that the column will stay up to date whenever it is changed, even if not via this method... Problematically the resulting value of the trigger isn't accessible inside the transaction (at least not that I was able to find). I tried flushes and savepoints but no matter what I did nothing worked :(
ewdurbin
commented
Mar 2, 2022
| @@ -80,14 +82,19 @@ def __init__(self, session, *, ratelimiters=None, remote_addr, metrics): | |||
| ) | |||
| self.remote_addr = remote_addr | |||
| self._metrics = metrics | |||
| self.cached_get_user = functools.lru_cache()(self._get_user) | |||
There was a problem hiding this comment.
Side effect of scrambling with figuring out why I couldn't get the latest password_date value... but interestingly this may resolve a memory leak? https://rednafi.github.io/reflections/dont-wrap-instance-methods-with-functoolslru_cache-decorator-in-python.html
ewdurbin
force-pushed
the
invalidate_sessions_on_password_change
branch
from
b71b9f3
to
0bd0f62
Compare
ewdurbin
force-pushed
the
invalidate_sessions_on_password_change
branch
from
0bd0f62
to
2c1aad8
Compare
di
reviewed
Mar 2, 2022
di
reviewed
Mar 2, 2022
ewdurbin
force-pushed
the
invalidate_sessions_on_password_change
branch
from
2c1aad8
to
57458ac
Compare
ewdurbin
force-pushed
the
invalidate_sessions_on_password_change
branch
from
57458ac
to
61ce40b
Compare
Thanks @dstufft! db.refresh was the magic ticket to getting the resulting value from the trigger
ewdurbin
force-pushed
the
invalidate_sessions_on_password_change
branch
from
2835ba2
to
8309b00
Compare
|
Sanity check done locally:
|
di
approved these changes
Mar 2, 2022
| # we cannot say for sure, let it live its life. | ||
| return False | ||
|
|
||
| return current_password_timestamp != stored_password_timestamp |
There was a problem hiding this comment.
I like that the != comparison also covers our bases against time-travelers.
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
domdfcoding
pushed a commit
to domdfcoding/warehouse
that referenced
this pull request
Jun 7, 2022
…hanged (pypi#10859) * invalidate existing sessions for a given User when User.password is changed * set User.password_date whenever User.password is updated The trigger implementation is _best_ since it ensures that the column will stay up to date whenever it is changed, even if not via this method... Problematically the resulting value of the trigger isn't accessible inside the transaction (at least not that I was able to find). I tried flushes and savepoints but no matter what I did nothing worked :( * lint/translations * remove cache bypass for get_user, it is not necessary * translate string * cleanup 6942da2 * fix mass logout bug * revert to DB Trigger for password_date Thanks @dstufft! db.refresh was the magic ticket to getting the resulting value from the trigger * translations * explicitly flush before refresh to ensure modified state is maintained * Update warehouse/sessions.py Co-authored-by: Dustin Ingram <di@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10849.