Warehouse Home page #126
Merged
Warehouse Home page #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Contains a (currently non functioning) search box * Shows some basic stats about # of projects and # of downloads * Shows the 10 most recently updated projects
| from warehouse.legacy.urls import urls as legacy_urls | ||
|
|
||
|
|
||
| # Global URL Rules |
There was a problem hiding this comment.
"Global" seems like the wrong word here. Perhaps just "top level"?
|
Looks good, though I feel I should caution against introducing cute stuff like mobile support. I believe it unnecessarily complicates and distracts when the site design is going to be done as a separate task (well, I hope it is ;) |
|
Yea it is a separate task, it was literally adding a minor bit of CSS so I went ahead and did it because i'm a bit OCD :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview