Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin packaging to upper boundary #12664

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

miketheman
Copy link
Member

packaging 22.0 was released recently, removing a dependency on pyparsing, which is cool.

Since google-cloud-bigquery pins to pre-22, we cannot update our dependencies until that is allowed and released, as we will have conflicts between what is installed in non main.txt requirements.

Refs: googleapis/python-bigquery#1435

Signed-off-by: Mike Fiedler miketheman@gmail.com

`packaging` 22.0 was released recently, removing a dependency on
`pyparsing`, which is cool.

Since `google-cloud-bigquery` pins to pre-22, we cannot update our
dependencies until that is allowed and released, as we will have
conflicts between what is installed in non `main.txt` requirements.

Refs: googleapis/python-bigquery#1435

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman requested a review from a team as a code owner December 10, 2022 21:34
@miketheman miketheman added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Dec 10, 2022
@miketheman
Copy link
Member Author

Python Dep PRs will currently fail a make deps check due to the mismatch in finding that pyparsing disappears from the installed scope without the version pin, blocking the overall pipeline of merging Python dependencies.

@di di merged commit 48502f9 into pypi:main Dec 12, 2022
@miketheman miketheman deleted the miketheman/pin-packaging branch December 12, 2022 18:42
di added a commit to di/warehouse that referenced this pull request Jan 19, 2023
di added a commit that referenced this pull request Jan 20, 2023
* Revert "chore(deps): pin packaging to upper boundary (#12664)"

This reverts commit 48502f9.

* bump packaging from 21.3 to 23.0

* Updates for packaging==23.0 compatibility
di added a commit to di/warehouse that referenced this pull request Jan 20, 2023
di added a commit that referenced this pull request Jan 20, 2023
di added a commit to di/warehouse that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants