Document PyPI's protections against resurrection attacks #13720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
reviewed
May 22, 2023
Comment on lines
193
to
200
| To solve this issue, PyPI worked with GitHub to add the `repository_owner_id` | ||
| claim to OIDC tokens. This claim attests to the ID of the repository owner, | ||
| which is stable and permanent unlike usernames. When a trusted publisher is | ||
| configured, PyPI looks up the configured username's ID and stores it. During | ||
| API token minting, PyPI checks the `repository_owner_id` claim against the | ||
| stored ID and fails if they don't match. Through this process, only the original | ||
| GitHub user remains authorized to publish to their PyPI projects, even if they | ||
| change their username or delete their account. |
There was a problem hiding this comment.
We probably don't need the specific history here 🙂 -- we can just say "for GitHub-based publishers, PyPI always checks the repository_owner_id claim, since ..."
woodruffw
reviewed
May 22, 2023
woodruffw
reviewed
May 22, 2023
|
A few small nits, otherwise LGTM! |
Signed-off-by: Andrew Pan <a@tny.town>
di
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13469.