make the invalid-publisher err msg more informative
#13941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingy94@gmail.com>
woodruffw
suggested changes
Jun 14, 2023
There was a problem hiding this comment.
PyPI admins are the ultimate arbiters here, but I'm personally a -1 on the changes to the error messages here: I think they introduce more ambiguity than they resolve, unfortunately.
IMO a workable solution here would be to add another bulletpoint to the troubleshooting docs explicitly mentioning that any environment configured on PyPI needs to match the CI job's environment, and then include the troubleshooting URL in the error render on the gh-action-pypi-publish side.
In other words: IMO this change should be docs-only, and should be accompanied by a separate PR to the gh-action-pypi-publish action that updates the error message to include a link to the troubleshooting docs.
Signed-off-by: Keming <kemingy94@gmail.com>
di
reviewed
Jun 14, 2023
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
di
reviewed
Jun 15, 2023
di
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid-publisher: valid token, but no corresponding publisher pypa/gh-action-pypi-publish#138 (comment)