Update order of operations in password checking #14449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
reviewed
Aug 29, 2023
di
approved these changes
Aug 29, 2023
ewdurbin
force-pushed
the
basic_auth_check_ooo
branch
2 times, most recently
from
3a42cea
to
f5fa00d
Compare
ewdurbin
force-pushed
the
basic_auth_check_ooo
branch
from
23ece83
to
5e63b30
Compare
miketheman
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates order of operations when checking user passwords and frozen/disabled status to avoid leaking account status pre-auth.
Also along the way realized we don't invalidate user sessions once they've been frozen/disabled, since we block login we should probably also block them from doing anything.