-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the project and file upload limits in pypi on the FAQ page #14478
base: main
Are you sure you want to change the base?
Conversation
From #6192 (comment):
I think I agree, these variables can be found here: warehouse/warehouse/forklift/legacy.py Lines 78 to 80 in 281447f
|
c81adea
to
bfb451f
Compare
@di , updated the PR. Thanks for the suggestion. Please review if you have cycles |
c9c0be2
to
513db4c
Compare
513db4c
to
7009c5e
Compare
Does anyone know why this is awaiting response? This should be ready for review |
7009c5e
to
95df8ec
Compare
settings["warehouse.forklift.legacy.MAX_FILESIZE_MB"] = MAX_FILESIZE / ONE_MB | ||
settings["warehouse.forklift.legacy.MAX_PROJECT_SIZE_GB"] = ( | ||
MAX_PROJECT_SIZE / ONE_GB | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that this is the source of truth to these values everywhere, so instead of using MAX_FILESIZE
and MAX_PROJECT_SIZE
outside of this file, we should use the values from settings
.
Hi @SurenNihalani, are you able to resolve the conflicts here and address the review so we can merge this? Thanks! |
This is for #6192 . I had to create a new constants module because import warehouse.legacy leads to circular imports. Instead of resolving that, I went with creating a new file
Test Plan:
make build, make initdb, make serve and read http://localhost/help/#project-size-limit .
This is how it looks like:
Fixes #6192.