chore: surface event if proxy token mismatches #14499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/raise-if-token-mismatch
branch
2 times, most recently
from
f6b6998
to
1e49beb
Compare
If someone passes the proxy token and it doesn't match, we default to using the other block that pulls values off other headers. Instead of allowing that, send a sentry and dump the request. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/raise-if-token-mismatch
branch
from
1e49beb
to
b8a0f0d
Compare
ewdurbin
approved these changes
Sep 7, 2023
ewdurbin
changed the title
dstufft
reviewed
Sep 7, 2023
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
That was me validating ^, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone passes the proxy token and it doesn't match, we default to using the other block that pulls values off other headers.
Instead of allowing that, send a sentry
and dump the request.