Add dynamic to releases table for Metadata 2.2
#15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
di
reviewed
Feb 22, 2024
warehouse/migrations/versions/778f1c01a019_release_add_provides_extra_and_dynamic_.py
Outdated
Show resolved
Hide resolved
di
reviewed
Feb 22, 2024
warehouse/migrations/versions/778f1c01a019_release_add_provides_extra_and_dynamic_.py
Outdated
Show resolved
Hide resolved
di
reviewed
Feb 22, 2024
warehouse/migrations/versions/778f1c01a019_release_add_provides_extra_and_dynamic_.py
Outdated
Show resolved
Hide resolved
|
Thanks! I think we want to get the valid values from a shared Enum as mentioned in https://github.com/pypi/warehouse/pull/13606/files#r1499979019 instead, holding off on merging this until we resolve that discussion. |
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
konstin
force-pushed
the
add-dynamic-to-database-for-metadata-2.2
branch
from
612e82c
to
99229a4
Compare
|
I had some git problems, i squashed this into one commit now and rebased the other PR on top of it |
di
approved these changes
Feb 23, 2024
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #13606 according to #13606 (comment)
CC @di