tests: address randomness-related failures #15469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_simple_detail()` function has sorted the results by version, then filename, so update test conditions to sort similarly as well. Exposed with: --randomly-seed=105155306 --randomly-seed=1843708888 --randomly-seed=19699634 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Other tests paginating expect a page-like object instead of the list of items, so supply one. Exposed via: --randomly-seed=3227833760 --randomly-seed=235656747 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
When using `factory.Sequence()` for a database-controlled sequence column, we can get into a weird state where we're reusing the sequence since we've flushed already. Since we already rely on the database to generate the ID for us, we don't have to supply it ourselves as part of the factory. If we ever *do* want to set a specific id for a JournalEntry, we would use a keyword argument like `JournalEntryFactory.create(id=...)` Exposed via: --randomly-seed=2329742959 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
di
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #15398