lets just try dockah #15585
Merged
lets just try dockah #15585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f03fd35.
ewdurbin
commented
Mar 14, 2024
| sudo apt -y install libcurl4-openssl-dev libssl-dev pkg-config libxml2-dev libxslt-dev | ||
| - uses: actions/setup-python@v5 | ||
| - name: Expose GitHub Runtime | ||
| uses: crazy-max/ghaction-github-runtime@v3 |
There was a problem hiding this comment.
Exposes the necessary variables for the gha cache type to work for docker layers, see https://docs.docker.com/build/cache/backends/gha/#authentication
| cache-source: var-lib-apt | ||
| cache-target: /var/lib/apt | ||
| skip-extraction: ${{ steps.cache-var-lib-apt.outputs.cache-hit }} | ||
| - name: inject root-cache-pip into docker |
There was a problem hiding this comment.
these combined with the normal "cache" steps help us persist RUN --mount=type=cache caches between runs improving our pip/apt/npm install times.
| - name: Dependencies | ||
| command: bin/github-actions-deps |
There was a problem hiding this comment.
something goes wrong trying to run git in the container. without the gha specific deps job... we burn an extra minute of CI every run :/
| @@ -39,7 +39,7 @@ build-mos: compile-pot | |||
| translations: compile-pot | |||
| ifneq ($(GITHUB_ACTIONS), false) | |||
| cd ../../; \ | |||
| git diff --quiet ./warehouse/locale/messages.pot || (echo "There are outstanding translations, run 'make translations' and commit the changes."; exit 1) | |||
| cmp -s ./warehouse/locale/messages.pot /opt/warehouse/src/warehouse/locale/messages.pot || (echo "There are outstanding translations, run 'make translations' and commit the changes."; exit 1) | |||
There was a problem hiding this comment.
this leverages the fact that we have a copy of the messages.pot from the build step since git diff doesn't work in the container.
di
approved these changes
Mar 14, 2024
ewdurbin
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everything else involved (dev, prod) is docker, why not ci?
yeee, fucking, haw.
closes #15583.