Switch to using the "system font stack" #8982
Conversation
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| // SETTINGS - FONTS | |||
|
|
|||
| $base-font-family: "Source Sans Pro", "Helvetica", Arial, sans-serif; | |||
| $base-font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Helvetica, Arial, sans-serif, Apple Color Emoji, Segoe UI Emoji; | |||
| $code-font: "Source Code Pro", monospace; | |||
There was a problem hiding this comment.
Unrelated but I think we also need to consider something like Fira Code here (separate discussion needed)
There was a problem hiding this comment.
You mean a "system font stack" for the monospaced case?
Maybe https://github.com/pradyunsg/furo/blob/ecfee9c5a3872cfac72f5ee8c63c7d474ee8e60f/src/furo/assets/styles/variables/_index.scss#L41-L42 would work?
There was a problem hiding this comment.
Probably. But it's out of the scope of this PR.
There was a problem hiding this comment.
Please don’t use “BlinkMacSystemFont”; just using “system-ui” is enough in Blink-based browsers.
Have you checked this with DevTools? The italics version seems visually smaller which suggests that the font may still be different.
I don't think it knows how to format CSS. I guess you can change it any way you want as long as it remains readable.
I think you can mark PRs as Draft when you yourself think that it's not ready for review. P.S. I don't think I currently have the warehouse repo set up on my laptop but I've made this change via DevTools on the production instance. And in my env, it now selects Arial for both normal paragraph text and the emphasized one. |
|
Devtools for the two bits of text below. I think this means they are using the same font (not quite sure why FA shows up for the normal text)
This is with firefox on OSX |
|
As far as I can tell this is ready for reviewing. System font stack is used for all normal text (normal == not monospaced). |
|
Thanks @betatim for taking a look at this!
Looks like it's still in use by the admin interface CSS as well as some SVG logos and other templates. I'd be fine with dropping it in all those places and removing our dependency on However I'll leave this for @nlhkabu to approve since ultimately it has the effect of changing the font all of PyPI will render with. |
|
On my side, I'd prefer to maintain Source Sans Pro where we can. FYI, support in this font is coming (slowly....) - see: |
|
oh, and I should have said - thanks for your work on this @betatim! 🎉 |
Oh wow! I didn't know that this existed. I'll do some reading to find out what the answer is. If someone knows the answer to this question please post it (don't wait for me to find out first :D ) |
|
We could close this pull request and instead rely on the new version of Source Code Pro as @nlhkabu described on 23 Apr 2021. The two third-party changes that @nlhkabu referenced are now resolved:
I confirmed today that https://pypi.org/help/#file-size-limit now displays italic ”меншого” using:
|
That would work for me. I'll close this PR. Thanks for following up! |
This is a first attempt to close #8634 by switching to a system font stack.
Should I put a line break for the list of fonts? I ran
make reformathoping it would sort out my formatting issues but no luck :DI copied меншого to before the
<em>tag to make it easier to compare (that is why it appears twice). I think it now uses the same font.What should I do next? Are there things that can be cleaned up now that Source Sans Pro isn't in use any more?
Are there any conventions around adding
[WIP]to the PR title or marking it as draft for stuff which needs a bit of hand-holding from an experienced person?