Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket patch #6

Closed
DanEdens opened this issue Feb 15, 2020 · 1 comment
Closed

Websocket patch #6

DanEdens opened this issue Feb 15, 2020 · 1 comment

Comments

@DanEdens
Copy link
Contributor

DanEdens commented Feb 15, 2020

Apply the following patrch or Find either better solution to the timeout issue.

def disable_timeout_pyppeteer():
    import pyppeteer.connection
    original_method = pyppeteer.connection.websockets.client.connect
    def new_method(*args, **kwargs):
        kwargs['ping_interval'] = None
        kwargs['ping_timeout'] = None
        return original_method(*args, **kwargs)

    pyppeteer.connection.websockets.client.connect = new_method

Related issues:
Number 62
Number 267
Number 178
Number 170
Number 160
Others

@DanEdens
Copy link
Contributor Author

DanEdens commented Feb 15, 2020

O shoot this patch has already been applied to the Dev branch.

celestialhorizon pushed a commit to celestialhorizon/pyppeteer2 that referenced this issue Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant