-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This should resolve test_subscript and test_declare_matrix test in python3.9 #64 #67
Conversation
Hello @amodwani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-11-23 12:43:49 UTC |
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 69.84% 69.81% -0.04%
==========================================
Files 20 20
Lines 4063 4065 +2
Branches 779 780 +1
==========================================
Hits 2838 2838
- Misses 1020 1021 +1
- Partials 205 206 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a simpler fix is possible and will send one in a separate PR along with regression testing for 3.9.
return '%s[%s]' % ( | ||
self.visit(node.value), self.visit(node.slice.value) | ||
) | ||
if (isinstance(node.slice, ast.Constant) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be compressed into:
if isinstance(node.slice, (ast.Constant, ast.Name, ast.BinOp, ast.Subscript)):
...
Thank you for this, closing since this is superseded by #68 . |
@prabhuramachandran ,As I am new to this can you check this out.
As new changes in ast in pyhton 3.9.
#64
After this change