Setup properties in the end & correct exact sol

pypr · Apr 16, 2020 · 0589377 · 0589377
1 parent 8f29c29
commit 0589377
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/pysph/examples/cavity.py b/pysph/examples/cavity.py
@@ -101,9 +101,6 @@ def create_particles(self):
 
         print("Lid driven cavity :: Re = %d, dt = %g" % (self.re, self.dt))
 
-        # add requisite properties to the arrays:
-        self.scheme.setup_properties([fluid, solid])
-
         # setup the particle properties
         volume = dx * dx
 
@@ -115,21 +112,25 @@ def create_particles(self):
         fluid.rho[:] = rho0
         solid.rho[:] = rho0
 
-        # volume is set as dx^2
-        fluid.V[:] = 1. / volume
-        solid.V[:] = 1. / volume
-
         # smoothing lengths
         fluid.h[:] = hdx * dx
         solid.h[:] = hdx * dx
 
         # imposed horizontal velocity on the lid
         solid.u[:] = 0.0
         solid.v[:] = 0.0
+
         for i in range(solid.get_number_of_particles()):
             if solid.y[i] > L:
                 solid.u[i] = Umax
 
+        # add requisite properties to the arrays:
+        self.scheme.setup_properties([fluid, solid])
+
+        # volume is set as dx^2
+        fluid.V[:] = 1. / volume
+        solid.V[:] = 1. / volume
+
         return [fluid, solid]
 
     def post_process(self, info_fname):

diff --git a/pysph/examples/poiseuille.py b/pysph/examples/poiseuille.py
@@ -160,7 +160,8 @@ def _plot_ke_history(self):
         t, ke = get_ke_history(self.output_files, 'fluid')
         plt.clf()
         plt.plot(t, ke)
-        plt.xlabel('t'); plt.ylabel('Kinetic energy')
+        plt.xlabel('t')
+        plt.ylabel('Kinetic energy')
         fig = os.path.join(self.output_dir, "ke_history.png")
         plt.savefig(fig, dpi=300)
         return t, ke
@@ -181,14 +182,14 @@ def _plot_u_vs_y(self):
         fx = self.fx
         nu = self.nu
 
-        ye = np.arange(-d, d+1e-3, 0.01)
-        ue = -0.5 * fx/nu * (ye**2 - d*d)
-        ye += d
+        ye = np.linspace(0, self.Ly, 100)
+        ue = 0.5 * fx/nu * ye*(self.Ly - ye)
         from matplotlib import pyplot as plt
         plt.clf()
         plt.plot(ye, ue, label="exact")
         plt.plot(y, u, 'ko', fillstyle='none', label="computed")
-        plt.xlabel('y'); plt.ylabel('u')
+        plt.xlabel('y')
+        plt.ylabel('u')
         plt.legend()
         plt.title('Velocity profile at %s'%tf)
         fig = os.path.join(self.output_dir, "comparison.png")