Fix build and tests #390
Merged
Fix build and tests #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like extern fabs() in linalg3.pyx is assumed to have c++ linkage as linalg3.cpp file is generated. However, this fabs() ends up conflicting with the declaration with c linkage from /usr/include/x86_64-linux-gnu/bits/mathcalls.h on ubuntu github actions runner.
Builds were failing on windows github actions runner due to some conflict involving fmax() and fmin(). Seems like fmax() and fmin() were defined soleley for windows as they are a part of C99 standard but earlier MSVC not support C99 features fully. But now, MSVC supports it. So, it is no longer required.
also upgrade pip setuptools wheel each time tests run
not from pypi
With Cython 3.0, on github actions: - All openmp tests fail on windows. - Elliptical drop with openmp fails on ubuntu due to timeout. - All openmp tests pass on macos runner - test_compressed_octree_has_lesser_depth_than_octree fails Pinning cython<3.0 to fix these failures.
prabhuramachandran
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.