Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Deprecate Transformer.from_proj? #1161

Open
snowman2 opened this issue Oct 11, 2022 · 0 comments
Open

MNT: Deprecate Transformer.from_proj? #1161

snowman2 opened this issue Oct 11, 2022 · 0 comments
Milestone

Comments

@snowman2
Copy link
Member

snowman2 commented Oct 11, 2022

from_proj was added based on pyproj 1 patterns of using the Proj objects with the transformer. However, with PROJ 6+ and pyproj 2+, the CRS object should be the object used when creating transformers.

from_proj does not have all of the kwargs that from_crs has and that was mainly because from_crs should be the method used and there isn't much point in supporting both. Additionally, the Proj object has some additional overhead as it creates a Transformer and a CRS when initialized.

I am thinking that removing from_proj will remove confusion.

Compatibility: from_proj was added in the initial version of the transformer in pyproj 2.1.0. from_crs was added at the same time, so if users modify their code to use from_crs instead it will also be backwards compatible.

Does anyone have good reasons why from_proj should stay?

@snowman2 snowman2 pinned this issue Oct 11, 2022
@snowman2 snowman2 added this to the 3.4.1 milestone Oct 11, 2022
@snowman2 snowman2 changed the title Deprecate Transformer.from_proj? MNT: Deprecate Transformer.from_proj? Oct 11, 2022
@snowman2 snowman2 mentioned this issue Nov 2, 2022
@pyproj4 pyproj4 deleted a comment from bwoodsend Nov 2, 2022
@snowman2 snowman2 unpinned this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant