Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPE: Explicit optional & other fixes #1179

Merged
merged 1 commit into from Nov 12, 2022
Merged

TYPE: Explicit optional & other fixes #1179

merged 1 commit into from Nov 12, 2022

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Nov 12, 2022

note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True

https://peps.python.org/pep-0484/

Type checkers should move towards requiring the optional type to be made explicit.

@snowman2 snowman2 added this to the 3.4.1 milestone Nov 12, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1179 (933d4e3) into main (8cfb95b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          18       18           
  Lines        1707     1707           
=======================================
  Hits         1642     1642           
  Misses         65       65           
Impacted Files Coverage Δ
pyproj/proj.py 97.72% <ø> (ø)
pyproj/sync.py 87.50% <ø> (ø)
pyproj/transformer.py 94.95% <ø> (ø)
pyproj/crs/crs.py 98.07% <100.00%> (ø)
pyproj/geod.py 97.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snowman2 snowman2 merged commit 07bf470 into pyproj4:main Nov 12, 2022
@snowman2 snowman2 deleted the lnt branch November 12, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant