ENH: Add single point versions of transform, fwd, inv #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
greglucas
force-pushed
the
transform-point
branch
3 times, most recently
from
145d9a4
to
a381410
Compare
snowman2
reviewed
Dec 16, 2022
snowman2
reviewed
Dec 16, 2022
When transforming single points, this can add a significant speed benefit.
greglucas
force-pushed
the
transform-point
branch
from
a381410
to
dcc2af8
Compare
Codecov Report
@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
- Coverage 96.25% 96.17% -0.09%
==========================================
Files 20 20
Lines 1791 1829 +38
==========================================
+ Hits 1724 1759 +35
- Misses 67 70 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
snowman2
reviewed
Dec 17, 2022
| @overload | ||
| def transform_point( # pylint: disable=invalid-name | ||
| self, | ||
| x: float, |
There was a problem hiding this comment.
It would be good for theses kwargs to be consistent with transform.
|
See #1204 for cython version of |
|
Closing in favor of #1204. Will open a separate PR for the Geod point functions. |
Just adding the reference here. Thanks for this work @greglucas @snowman2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transforming single points, this can add a significant speed benefit.
history.rstfor all changesapi/*.rstfor new API