Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added class based version of Transformer #189

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Added class based version of Transformer #189

merged 4 commits into from
Mar 14, 2019

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Mar 13, 2019 •
edited

@snowman2
Copy link
Member Author

This is a start. Definitely needs documentation, tests, etc...

@snowman2 snowman2 changed the title initial attempt at class based version of Transformer WIP: initial attempt at class based version of Transformer Mar 13, 2019
@snowman2
Copy link
Member Author

This kind of refactor might be appropriate for a minor version increment instead of a patch. Thoughts on 2.1.0 for this change?

@jswhit
Copy link
Collaborator

jswhit commented Mar 13, 2019

Yes, I agree. I'll go ahead and release 2.0.2 today.

@snowman2 snowman2 mentioned this pull request Mar 13, 2019
Closed
@snowman2 snowman2 changed the title WIP: initial attempt at class based version of Transformer Added class based version of Transformer Mar 13, 2019
@snowman2
Copy link
Member Author

@jswhit if the tests pass & you are happy with the changes, it should be good to merge in.

@jswhit
Copy link
Collaborator

jswhit commented Mar 13, 2019

Looks great to me! How about a version bump to 2.1.0 and an entry in history.rst?

After I merge this I'll do the repo move to pyproj4.

@snowman2
Copy link
Member Author

Sounds good. I will do that this evening 👍

@snowman2
Copy link
Member Author

Should I rebuild the docs as well?

@jswhit
Copy link
Collaborator

jswhit commented Mar 13, 2019

Sure

@snowman2
Copy link
Member Author

Should be good to go now.

@jswhit jswhit merged commit 43d0170 into pyproj4:master Mar 14, 2019
@jswhit
Copy link
Collaborator

jswhit commented Mar 14, 2019

Thanks @snowman2 - this is really nice.

@snowman2
Copy link
Member Author

Glad you like it.

@ghost ghost mentioned this pull request Jun 4, 2019
Closed
@snowman2 snowman2 deleted the transformer branch September 2, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snowman2 @jswhit