-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added class based version of Transformer #189
Conversation
This is a start. Definitely needs documentation, tests, etc... |
This kind of refactor might be appropriate for a minor version increment instead of a patch. Thoughts on 2.1.0 for this change? |
Yes, I agree. I'll go ahead and release 2.0.2 today. |
@jswhit if the tests pass & you are happy with the changes, it should be good to merge in. |
Looks great to me! How about a version bump to 2.1.0 and an entry in history.rst? After I merge this I'll do the repo move to pyproj4. |
Sounds good. I will do that this evening 👍 |
Should I rebuild the docs as well? |
Sure |
Should be good to go now. |
Thanks @snowman2 - this is really nice. |
Glad you like it. |
#187