Update setup.py PROJ version checking #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In check_proj_version() add installed PROJ version to error message, return proj_version, use pkg_resources.parse_version() to provide a more featureful Version object.
After @snowman2 asked about the matter, so I just dug into it. This is the better Version object because distutils LooseVersion and StrictVersion are poorly documented and support the superceeded PEP 386. pkg_resources.parse_version follows PEP 440, and pkg_resources is provided by setuptools.
The returned proj_version value could be useful if there needs to be some other steps that have to be taken for future version of PROJ, while supporting older PROJ versions with operators such as
version >= parse_version('6.1.0')
.So on my system it provides this error message