Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate powerplantmatching #116

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

koen-vg
Copy link
Collaborator

@koen-vg koen-vg commented Oct 12, 2021

Add a snakemake rule to generate "resources/powerplants.csv", which uses a fork of powerplantmatching. The resulting powerplants are added to the network in the "add_electricity" rule.

I will get in touch with upstream powerplantmatching to see if we can address our needs upstream, so we don't have to maintain our own fork.

Add a snakemake rule to generate "resources/powerplants.csv", which
uses a fork of powerplantmatching. The resulting powerplants are added
to the network in the "add_electricity" rule.
@pz-max
Copy link
Member

pz-max commented Oct 12, 2021

Hey @koen-vg, I am not sure but I think powerplantmatching had a pull request recently that fixed the initial issue we had (probably avoids our fork)?

@koen-vg
Copy link
Collaborator Author

koen-vg commented Oct 12, 2021

Hey @koen-vg, I am not sure but I think powerplantmatching had a pull request recently that fixed the initial issue we had (probably avoids our fork)?

They fixed one issues, but other issues still remain, so right at this point we still need the fork. There are two issues (addressed in the two most recent commits to the fork, see https://github.com/koen-vg/powerplantmatching/commits/pypsa-africa):

  • powerplantmatching still had a bug related to custom config, but that should be easy to address upstream.
  • More seriously, I modified powerplantmatching to use exclusively alpha2 country codes, due to country name inconsistencies between different databases. This breaks compatibility, so we could suggest to upstream to include this as an options (which would require a little bit of extra work).

@pz-max
Copy link
Member

pz-max commented Oct 12, 2021

Hey @koen-vg, I am not sure but I think powerplantmatching had a pull request recently that fixed the initial issue we had (probably avoids our fork)?

They fixed one issues, but other issues still remain, so right at this point we still need the fork. There are two issues (addressed in the two most recent commits to the fork, see https://github.com/koen-vg/powerplantmatching/commits/pypsa-africa):

* powerplantmatching still had a bug related to custom config, but that should be easy to address upstream.

* More seriously, I modified powerplantmatching to use exclusively alpha2 country codes, due to country name inconsistencies between different databases. This breaks compatibility, so we could suggest to upstream to include this as an options (which would require a little bit of extra work).

Great detail Koen, let's try to get the issue fixed upstream. Happy to discuss that more on Friday :)

@pz-max pz-max merged commit c17a941 into pypsa-meets-earth:new-main Oct 15, 2021
@davide-f davide-f mentioned this pull request Oct 27, 2021
56 tasks
pz-max added a commit that referenced this pull request Sep 24, 2022
Integrate powerplantmatching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants