Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Update osm_data_cleaning.py #158

Merged
merged 6 commits into from
Nov 21, 2021
Merged

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Nov 21, 2021

A duplicate of #157 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/pypsa-meets-africa/pypsa-africa.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@pz-max pz-max merged commit ceb92fd into new-main Nov 21, 2021
@pz-max
Copy link
Member

pz-max commented Nov 21, 2021

closes #153

@pz-max
Copy link
Member

pz-max commented Nov 21, 2021

@oayana well done! Welcome to the contributor list. You made it 👍
@davide-f just FYI. The code could potentially lead to some issues in future but is a nice quick solution.

@pz-max pz-max deleted the restyled/osm_data_clean branch November 21, 2021 15:59
@davide-f
Copy link
Member

davide-f commented Nov 22, 2021

@pz-max in my computer this version breaks. I add few comments; if you run snakemake -j1 clean_osm_data --force some problem rise:

  • line 344 sub.notnull().all() -> sub.notnull().all().all() [easy fix]
  • the logic of function split_cells_multiple does not account cases where cables has the ";" but voltage does not
  • the fix is not flexible to account for >2 cables, yet that shouldn't be difficult to fix

Did the code work on yours?

@davide-f
Copy link
Member

a9a2d8f solves the first two problems mentioned above

@pz-max
Copy link
Member

pz-max commented Nov 22, 2021

Hi @davide-f, I didn't check th full workflow just the code. I will now work on the CI to have a check running for the whole workflow. That stuff gets a serious problem now 💯

pz-max pushed a commit that referenced this pull request Sep 24, 2022
This closes #155 

* Update osm_data_cleaning.py
* Linted by restyler

Co-authored-by: oayana <91368941+oayana@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants