Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable add_hydro feature and parallel downloading of osm data #232

Merged
merged 26 commits into from Jan 20, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Jan 19, 2022

Changes proposed in this Pull Request

The aim of this pull request is to enable hydro script in all features; going beyond the current version where only run-of-river works.

Moreover, it integrates parallel computing for downloading osm data

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@davide-f davide-f marked this pull request as ready for review January 20, 2022 20:36
@davide-f davide-f changed the title enable add_hydro feature enable add_hydro feature and parallel downloading of osm data Jan 20, 2022
@davide-f davide-f merged commit 7e8f30f into main Jan 20, 2022
@davide-f davide-f deleted the enable_hydro branch February 8, 2022 18:00
pz-max pushed a commit that referenced this pull request Sep 24, 2022
enable add_hydro feature and parallel downloading of osm data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants