Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean_osm_data script run with landlocked country #341

Merged
merged 6 commits into from
May 19, 2022
Merged

Make clean_osm_data script run with landlocked country #341

merged 6 commits into from
May 19, 2022

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented May 18, 2022

Closes #340

Changes proposed in this Pull Request

  • Pass only onshore shape if the offshore shape does not exist. Note. Landlock countries might cause later scripts issues, hence, this fix is only valid for the clean_osm_data script.
  • Change append to concat functions
  • Read snakemake input at the beginning of script execution

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f merged commit 1f6209a into pypsa-meets-earth:main May 19, 2022
pz-max added a commit that referenced this pull request Sep 24, 2022
* contrib-readme-action has updated readme

* deal with empty offshore shape

* append to concat

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add release note

Co-authored-by: contrib-readme-bot <contrib-readme-action@noreply.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.geojson data not recognized
2 participants