Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powerplantmatching problem for DRC #359

Merged
merged 2 commits into from
May 31, 2022
Merged

Fix powerplantmatching problem for DRC #359

merged 2 commits into from
May 31, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented May 31, 2022

Closes #349

Changes proposed in this Pull Request

This fix aims at addressing the issue discussed in #349.
The country name standard in pycountry sometimes is conflicting to the value used in other datasets, such as GEO and GPD.
In the specific case of 349, DRC is named "Congo, The Democratic Republic of" (pycountry), while in GEO and GPD is "Democratic Republic of Congo".
That lead to conflicts that are now fixed, yet to be verified at Africa and Earth scale.
It is worth mentioning on pycountry as well.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f mentioned this pull request May 31, 2022
2 tasks
@davide-f davide-f marked this pull request as ready for review May 31, 2022 14:42
@pz-max
Copy link
Member

pz-max commented May 31, 2022

Quite a special fix 👍 Needs probably revision at later stage.
Let's merge and wait until the next problem arise

@pz-max pz-max merged commit 46f2756 into pypsa-meets-earth:main May 31, 2022
@davide-f davide-f deleted the fix_build_powerplants branch June 9, 2022 22:45
pz-max added a commit that referenced this pull request Sep 24, 2022
Fix powerplantmatching problem for DRC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with powerplantsmatching
2 participants