Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simplify network overestimation #443

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Fix simplify network overestimation #443

merged 4 commits into from
Aug 28, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Aug 19, 2022

Closes #283

Changes proposed in this Pull Request

This PR aims at fixing the problem of the simplify network approach that overestimates the line capacity, and quite consistently.
image

With the proposed fix, that issue is solved: the calculation of the number of circuits is adapted according to the ratio of voltages and nominal capacities of the lines.
image

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member Author

Before merging this, I'd like to have the opinion by the PyPSA-Eur group.
I'll open a PR also in PyPSA-Eur soon

@davide-f davide-f added this to the Version 0.1 milestone Aug 22, 2022
@pz-max pz-max enabled auto-merge August 28, 2022 16:12
Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison suggests that the changes successfully fix the issue

@pz-max pz-max changed the title Fix simplify voltage problem Fix simplify network overestimation Aug 28, 2022
@pz-max pz-max merged commit d2db8be into pypsa-meets-earth:main Aug 28, 2022
@pz-max pz-max mentioned this pull request Sep 7, 2022
pz-max added a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line capacity overestimation check in simplify network
2 participants