Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to country converter #493

Merged
merged 10 commits into from
Nov 10, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Oct 25, 2022

Closes #368

Changes proposed in this Pull Request

This PR aims at moving from pycountry to the more up to date and versatile country_converter package to convert the country names

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f davide-f marked this pull request as ready for review October 25, 2022 20:22
@davide-f
Copy link
Member Author

mmm they ended up being a lot of commits, I may reduce them in case.

By the way this PR is ready for review

@davide-f davide-f merged commit b3c9c83 into pypsa-meets-earth:main Nov 10, 2022
@davide-f davide-f deleted the move_to_country_converter branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from pycountry to country_converter
1 participant