Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not-connected nodes #530

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

davide-f
Copy link
Member

@davide-f davide-f commented Dec 2, 2022

Closes #506

Changes proposed in this Pull Request

This is a simple fix that avoids the problem of leaving the connected nodes.
However, there is the need to check and verify the effect of removing the sub_networks.

I don't think there is the need to add a release_note for this.
Rather, there is the need to verify the effect of disregarding the sub_network and any problem/bug that may rise would deserve a release_note

The output on tutorial is the following:
image

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max pz-max merged commit b6fd5e0 into pypsa-meets-earth:main Dec 6, 2022
@davide-f davide-f deleted the fix_unconnected_nodes branch March 16, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolated buses are kept after clustering
2 participants