Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description on custom_powerplants use #672

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

carlosfv92
Copy link
Contributor

*Added some additional lines in the commented section of the build_powerplants.py file, with some comments on how to allow the proper configuration/formating of a custom_powerplants.csv file that can be used in the buil_powerplants rule

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • [x ] I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • [x ] I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

*Added some additional lines in the commented section of the build_powerplants.py file, with some comments on how to allow the proper configuration/formating of a custom_powerplants.csv file that can be used in the buil_powerplants rule
@carlosfv92 carlosfv92 changed the title Changes made:Added some additional lines in the commented section of the build_powerplants.py file, with some comments on how to allow the proper configuration/formating of a custom_powerplants.csv file that can be used in the buil_powerplants rule Changes made:Additional description on how to use/define the custom_powerplants.csv file in the buil_powerplants rule Apr 7, 2023
@pz-max pz-max changed the title Changes made:Additional description on how to use/define the custom_powerplants.csv file in the buil_powerplants rule Add description on custom_powerplants use Apr 7, 2023
@pz-max
Copy link
Member

pz-max commented Apr 7, 2023

Hi @carlosfv92 ,
Thanks for the contribution. The documentation string is automatically used to compile the documentation. Your current contribtuion looks like this: image

I would recommend compiling the documentation locally. We have some documentation how to do this here. I observed some issue with the docs and will raise in a moment a PR on your fork 👍

@pz-max
Copy link
Member

pz-max commented Apr 7, 2023

@carlosfv92 , please review and accept this PR carlosfv92#2 (will be automatically added here when you accept)

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now. Thanks for the contribution @carlosfv92 :)

@pz-max pz-max merged commit 64f1726 into pypsa-meets-earth:main Apr 11, 2023
@carlosfv92
Copy link
Contributor Author

Happy to help!

@carlosfv92 carlosfv92 deleted the Custom_powerplants_comments branch June 12, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants