Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gadm layer bug #684

Merged
merged 2 commits into from
Apr 15, 2023
Merged

fix gadm layer bug #684

merged 2 commits into from
Apr 15, 2023

Conversation

yerbol-akhmetov
Copy link
Collaborator

@yerbol-akhmetov yerbol-akhmetov commented Apr 15, 2023 •
edited
Loading

Changes proposed in this Pull Request

Here we propose changes to build_shapes.py to fix gadm bug introduced by #670

What was before: KZ.1
Fixed version now: KZ.1.1_1

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

pz-max
pz-max approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yerbol-akhmetov. Looks good.

@pz-max pz-max merged commit 60fd12d into pypsa-meets-earth:main Apr 15, 2023
@yerbol-akhmetov yerbol-akhmetov deleted the gadm branch April 15, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pz-max pz-max pz-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yerbol-akhmetov @pz-max