Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zenodo handler #688

Merged
merged 5 commits into from
Apr 18, 2023
Merged

add zenodo handler #688

merged 5 commits into from
Apr 18, 2023

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented Apr 17, 2023

Closes #643

Changes proposed in this Pull Request

  • Add zenodo_handler.py to upload and update data via API from code.
  • Update zenodo links

Enables:

  • massive, mutlifile data upload to zenodo via CLI
  • automatic link update with update e.g. we could write in future automatically the bundle_config.yaml with the information

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max pz-max requested a review from davide-f April 17, 2023 09:56
@pz-max
Copy link
Member Author

pz-max commented Apr 17, 2023

Ready for review

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me!
As a comment on the structure, these "non-workflow scripts" may be placed in a separate folder.
Currently, this is the 2nd or 3rd file that does not belong to the workflow.
It could be good to discuss about that.

The zenodo stuff for the CI is needed soon; the restructuring of the files to separate "non-workflow" scripts may be included in another PR if you prefer.

@pz-max
Copy link
Member Author

pz-max commented Apr 18, 2023

Thanks for the review. The files are now in a non_workflow folder.
Feel free to merge if it is ok now @davide-f :)

@davide-f davide-f merged commit 3dd94b0 into pypsa-meets-earth:main Apr 18, 2023
@davide-f
Copy link
Member

Merged :)

@pz-max pz-max deleted the zenodo branch April 18, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule to automatically upload datakits to zenodo
2 participants