Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos in docstrings #695

Merged
merged 14 commits into from
Apr 21, 2023
Merged

Conversation

pitmonticone
Copy link
Contributor

@pitmonticone pitmonticone commented Apr 21, 2023

Changes proposed in this Pull Request

I've just fixed a few typo in docstrings and comments.

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spell lint :) just one minor change is required. Could you fix this?

@@ -116,7 +116,7 @@ def get_transform_and_shape(bounds, res, out_logging):

def unify_protected_shape_areas(inputs, natura_crs, out_logging):
"""
Iterates thorugh all snakemake rule inputs and unifies shapefiles (.shp) only.
Iterates thorough all snakemake rule inputs and unifies shapefiles (.shp) only.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be through?

Copy link
Contributor Author

@pitmonticone pitmonticone Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sorry. I'll fix it in a moment.

@pz-max
Copy link
Member

pz-max commented Apr 21, 2023

@pitmonticone Could you also please confirm here that this contribution can be relicensed to AGPL in case the community decides so?
There are some relicensing discussions ongoing: #693

@pitmonticone
Copy link
Contributor Author

Thanks for the spell lint :) just one minor change is required. Could you fix this?

Ops, sorry. Done.

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pitmonticone
Copy link
Contributor Author

@pitmonticone Could you also please confirm here that this contribution can be relicensed to AGPL in case the community decides so?

There are some relicensing discussions ongoing: #693

Confirmed in the discussion thread with 🏆. Thanks.

@pz-max pz-max merged commit 2f43229 into pypsa-meets-earth:main Apr 21, 2023
@pz-max
Copy link
Member

pz-max commented Apr 21, 2023

Welcome as contributor @pitmonticone 🥇

@pitmonticone
Copy link
Contributor Author

Thank you very much @pz-max for the development and maintenance of all these great open-source research-quality packages!

Let me know if you believe it could be helpful if I join this GitHub organisation as a member. Happy to help when I find the time.

@pz-max
Copy link
Member

pz-max commented Apr 21, 2023

@pitmonticone, thanks for the offer. It probably just makes sense to make you a org. member in case you prove to be a long-term contributor. But sure, we will inform you if it makes sense otherwise 👍

@pitmonticone
Copy link
Contributor Author

It sounds right to me. Thanks a lot for the quick review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants