Fix an error in simplify_network when to_substations simplification flag is on #708
Conversation
ekatef
force-pushed
the
fix_to_subs_clustering
branch
from
2ad4a37
to
bea3ebb
Compare
|
@davide-f, I think that is ready for the review |
|
As a comment, a reason for the issue was referring to |
scripts/simplify_network.py
Outdated
| n.buses.assign(bus_index=n.buses.index.get_level_values(0)) | ||
| .loc[i_suffic_load] | ||
| .groupby("country")["bus_index"] | ||
| .first() | ||
| .to_dict() |
There was a problem hiding this comment.
For consistency, I'd use "bus_id" instead of bus_index.
Is there a specific reason for this naming?
There was a problem hiding this comment.
Agree, revised
No rational reason, just a habit to keep the original data :)
Thank you! Fixed :) |
scripts/simplify_network.py
Outdated
| @@ -658,7 +659,11 @@ def merge_isolated_nodes(n, threshold, aggregation_strategies=dict()): | |||
|
|
|||
| # all the nodes to be merged should be mapped into a single node | |||
| map_isolated_node_by_country = ( | |||
| n.buses.loc[i_suffic_load].groupby("country")["bus_id"].first().to_dict() | |||
| n.buses.assign(bus_id=n.buses.index.get_level_values(0)) | |||
There was a problem hiding this comment.
Sorry a comment: why get_level_values here? isn't buses.index enough?
There was a problem hiding this comment.
Our data structure seem to be quite flexible, while multi-indexing is a usual pythonic practice. So, I thought it could be natural to use a general approach
However, looking into the code, it seems that we assume everywhere that n.buses always only one index. So, get_level_values(0) looks like over-complication. Removed
Have removed over-complication :) |
|
Super! Merging:) |
Closes #646
Changes proposed in this Pull Request
Checklist
envs/environment.yamlandenvs/environment.docs.yaml.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.