Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement license change #733

Merged
merged 1 commit into from
May 20, 2023
Merged

implement license change #733

merged 1 commit into from
May 20, 2023

Conversation

pz-max
Copy link
Member

@pz-max pz-max commented May 19, 2023

Closes #693

Changes proposed in this Pull Request

License change from GPL to AGPL

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member Author

pz-max commented May 19, 2023

@davide-f @ekatef FYI. I think we can merge this ASAP.
Probably also be good to push another release such that there is a clear difference.
Suggesting v0.3.0 as it is a major change. But I am also fine with other decisions.

@ekatef
Copy link
Collaborator

ekatef commented May 19, 2023

@pz-max a technical question: shouldn't we also re-implement contributions for which we don't have a consent for AGPL?

@pz-max
Copy link
Member Author

pz-max commented May 19, 2023

@ekatef i think that only applies for WAS addition? (Would be great ti get in this case Emres ok) The other code bits from the non voters are not in the main and replaced by new code as far as I could see

Old code will remain GPL licensed

@ekatef
Copy link
Collaborator

ekatef commented May 19, 2023

@ekatef i think that only applies for WAS addition? (Would be great ti get in this case Emres ok) The other code bits from the non voters are not in the main and replaced by new code as far as I could see

Old code will remain GPL licensed

@pz-max agree, it looks like a definition of WAS shortcut seems to be the only fragment which requires re-licensing. Have written to Emre asking for his consent

@davide-f
Copy link
Member

davide-f commented May 19, 2023

Personally, from a code point of view, there are no serious changes with the past v0.2, so, from the code point of view, I don't see the need for a major release.
Moreover v0.2 was released less than a month ago...

To have it as a major release we may have at least the revision of building shapes (PR nearly ready) and the finalization of the country-wise.

However, we don't need to wait for a major release for a new version and we can go for a 0.2.1.

What do you think? Do you want to give high visibility to the license change?

@pz-max
Copy link
Member Author

pz-max commented May 20, 2023

Thanks @ekatef. Emre just gave his ok 👍
Alright @davide-f. I think v0.2.1 is fine as well
Either @ekatef or @davide-f feel free to merge this PR

@davide-f
Copy link
Member

Super! Merging

@davide-f davide-f merged commit 8f49634 into pypsa-meets-earth:main May 20, 2023
2 of 4 checks passed
@pz-max pz-max deleted the license branch May 20, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change PyPSA-Earth license to MIT or AGPL
3 participants