Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove res from conventional ppls #769

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

yerbol-akhmetov
Copy link
Collaborator

@yerbol-akhmetov yerbol-akhmetov commented Jun 19, 2023

Changes proposed in this Pull Request

Here, I propose a slight modification of the code in add_electricity rule. Currently, in the attach_conventional_generators in add_electricity.py, non-conventional powerplants are also considered if extendable contains RES powerplants in config file. It does not currently create any problem, since those RES ppls added by attach_conventional_generators are rewritten by attach_wind_and_solar. In practice, only conventional powerplants need to be added by the attach_conventional_generators rule. I have faced this issue, when I tried further clustering (not only by carrier type, but also powerplant type (CHP and PP)).

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member

pz-max commented Jun 20, 2023

@yerbol-akhmetov good suggestion.

Do you think we can pass renewable_carriers here: attach_conventional_generators()
and instead of doing:
set(conventional_carriers) | (set(extendable_carriers["Generator"]) - {"solar", "onwind", "offwind-ac", "offwind-dc"})
do:
set(conventional_carriers) | (set(extendable_carriers["Generator"]) - set(renewable_carriers))

This is a bit more flexible in case new renewable carriers are added.

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Can you check my comment and avoid the hardcoded parts?

@yerbol-akhmetov
Copy link
Collaborator Author

I have replaced hard-coded part with more general renewable_carriers.

@pz-max pz-max merged commit 072b401 into pypsa-meets-earth:main Jun 20, 2023
3 checks passed
@yerbol-akhmetov yerbol-akhmetov deleted the remove_res_from_conv branch June 23, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants