Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Here, I propose a slight modification of the code in
add_electricity
rule. Currently, in theattach_conventional_generators
inadd_electricity.py
, non-conventional powerplants are also considered ifextendable
contains RES powerplants in config file. It does not currently create any problem, since those RES ppls added byattach_conventional_generators
are rewritten byattach_wind_and_solar
. In practice, only conventional powerplants need to be added by theattach_conventional_generators
rule. I have faced this issue, when I tried further clustering (not only by carrier type, but also powerplant type (CHP and PP)).Checklist
doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.