Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constraints: option to include global upper capacity limit #857

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

martacki
Copy link
Collaborator

@martacki martacki commented Sep 12, 2023

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@pz-max
Copy link
Member

pz-max commented Sep 12, 2023

Nice!

  • editing the release notes and
  • adding a brief documentation
    would be nice :)

@martacki
Copy link
Collaborator Author

Done @pz-max :) (you were too impacient ;) )

Copy link
Member

@pz-max pz-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🥇

@pz-max
Copy link
Member

pz-max commented Sep 12, 2023

In future, we should add tests also for the wildcards optins. But let's do that after Merge March 2024.

@pz-max pz-max merged commit 5fb9397 into main Sep 12, 2023
4 checks passed
@pz-max pz-max deleted the maxcaps branch September 12, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants