Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simplify_link bug with links #880

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Fix simplify_link bug with links #880

merged 2 commits into from
Oct 1, 2023

Conversation

davide-f
Copy link
Member

Closes #879

Changes proposed in this Pull Request

Fix bug mentioned in #879

FYI @Haiping007. Thanks for reporting :D The issue should soon be solved :)

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member Author

If CI passes, squash and merge is fine

@davide-f davide-f merged commit 2531c45 into main Oct 1, 2023
4 checks passed
@davide-f davide-f deleted the fix_KE branch October 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix needed to replace snakemake.config with snakemake.params
1 participant