Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of MGA cost bound #847

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

koen-vg
Copy link
Contributor

@koen-vg koen-vg commented Feb 26, 2024

Changes proposed in this Pull Request

I uncovered another issue with the MGA cost bound calculation; hopefully it really should be fixed now. The code would previously sometimes give the wrong number, but potentially only for a subset of components including already installed capacities or something. Anyway, the addition of the n.statistics.capex() and n.statistics.opex() dataframes doesn't work as-is and they need to be summed before adding the totals.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (baa242b) to head (d3d7870).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          26       26           
  Lines        7063     7063           
  Branches     1418     1418           
=======================================
  Hits         4679     4679           
  Misses       2102     2102           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabianHofmann
Copy link
Collaborator

thanks @koen-vg for the very digestible PRs

@fneum fneum disabled auto-merge March 3, 2024 13:41
@fneum fneum merged commit df7480c into PyPSA:master Mar 3, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants