This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
Default DHCP broadcast set to ''. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be derived from IP and subnet mask, unless set explicitly in CLI or config file. Fixes pypxe#132.
|
@lqu has this been tested? @psychomario if you approve (and it's been tested) I'll do a squash merge. |
|
@mmattioli I tested it manually in my environment (virtrualbox internal network). Is there a standard or automated test to run? |
|
Nope, we don't have any testing framework unfortunately. @mmattioli Looks good to me, go ahead and merge, Thanks! @lqu Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be derived from IP and subnet mask, unless set explicitly in CLI
or config file. Fixes #132 . Squashed from PR #131 .