Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

Python3 lowpass changes, zero impact to Python 2.6+ #156

Merged
merged 1 commit into from Jun 29, 2017
Merged

Python3 lowpass changes, zero impact to Python 2.6+ #156

merged 1 commit into from Jun 29, 2017

Conversation

lathama
Copy link
Contributor

@lathama lathama commented Jun 29, 2017

#147 broken apart with just the simple Python3 changes.

  1. setup.py will display the error now vs just failing
  2. exception splitting in dhcp.py works across Python versions
  3. file open changes, using io.open works across Python versions
  4. Print is a function, no future import needed. https://docs.python.org/2.6/library/functions.html#print

Disclaimer, I did the proof of concept for Ansible and Python3, not my first roller coaster.

will note the getuid vs geteuid in another PR

@psychomario
Copy link
Collaborator

👍

@psychomario psychomario merged commit 7dfe388 into pypxe:development Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants