Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to add a simple github action #4821

Merged
merged 9 commits into from Jan 2, 2024
Merged

Conversation

cfbolz
Copy link
Member

@cfbolz cfbolz commented Jan 2, 2024

No description provided.

@mattip
Copy link
Member

mattip commented Jan 2, 2024

cool. Of course this is not really portable since it builds on ubuntu-20.04. Is it worth building inside a manylinux_2014 docker? The artifact does have value for bisecting failures like the one in #4816.

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@cfbolz
Copy link
Member Author

cfbolz commented Jan 2, 2024

@mattip yeah, it's not properly portable at all, but without --make-portable it doesn't even work on my ubuntu 23.10 laptop, so this is still an improvement. I would like to merge this as it is, we can find out how to do Docker in a github action as a later step. ok for you?

@mattip
Copy link
Member

mattip commented Jan 2, 2024

Yes, makes sense.

@cfbolz
Copy link
Member Author

cfbolz commented Jan 2, 2024

cool, merging then 😊

@cfbolz cfbolz merged commit 27113aa into main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants