Branch/fix gc hooks (fixes #4899) #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem is that making sure the ActionFlag.fire method does not collect is not enough. it must also not change any pointer fields that would trigger the write barrier to be called (unfortunately we have no annotation for that). the bug in 4899 is an invariant in the GC being violated by a GC hook action being inserted into the linked list of actions. the new approach is to have a list of all actions and a bitfield that signifies if an action has fired. that way we don't need to put an action into a linked list at all if it fires, instead we just set the corresponding bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.