Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing sqlite3 symbols #4966

Closed
wants to merge 540 commits into from
Closed

Add some missing sqlite3 symbols #4966

wants to merge 540 commits into from

Conversation

devdanzin
Copy link
Contributor

This PR adds:

  • sqlite3.SQLITE_CREATE_VTABLE
  • sqlite3.SQLITE_DROP_VTABLE
  • sqlite3.SQLITE_FUNCTION
  • sqlite3.SQLITE_RECURSIVE
  • sqlite3.SQLITE_SAVEPOINT

Addresses part of #4962.

@mattip
Copy link
Member

mattip commented May 24, 2024

Looks good. This should target py3.9

mattip and others added 29 commits May 24, 2024 04:56
@mattip @devdanzin
refactor pytest raises into a context manager when 'eval'ing strings
39805dd
@mattip @devdanzin
updtae test_datetime for new error message, expired deprecation
f9f29a6
@mattip @devdanzin
updat test, python3.10 no longer errors
10a4ca0
@cfbolz @devdanzin
start refactoring for new position storage: make update_position take…
e9866c1 
… an ast

node as opposed to just the lineno
@mattip @devdanzin
revert 4a06412855d8, error formatting is not consistant
274fb10
@mattip @devdanzin
finixh hmac_digest implementation in _hashlib, fix HMAC.name
ba5c7d9
@mattip @devdanzin
fix test that raises ModuleNotFoundError
4fc7aae
@mattip @devdanzin
delay array import until after interpreter startup, so it is properly…
9b67a38 
… initialized
@mattip @devdanzin
add zip.__setstate__ for unpickling
8c64d20
@mattip @devdanzin
extend regex for error message
e33e96c
@mattip @devdanzin
enable passing bad_get function from _testcapi
ff07b3b
@mattip @devdanzin
remove deprecated conversion to int
d61110a
@mattip @devdanzin
port test_itertools.py skips from py3.9: cycle pickle is different, a…
91c0093 
…nd zip,ziplongest have different exceptions
@mattip @devdanzin
add readline.set_auto_history (from CPython3.6), skip test that uses …
6cb6849 
…INPUTRC
@mattip @devdanzin
resync with upstream
4abcf0f
@mattip @devdanzin
test, fix codecs.unregister (cfbolz around)
c27aac0
@mattip @devdanzin
test, fix encoding normalization (copy encodings.normalize, like CPyt…
334af5c 
…hon)
@mattip @devdanzin
unregister misbehaving codec after test
e8f8695
@mattip @devdanzin
make sure the encoding is valid when calling str.{de,en}code(encoding)
b326a35
@mattip @devdanzin
update for pypy3.10
51b35d8
@mattip @devdanzin
start fixing test_typing
6a43099
@mattip @devdanzin
GenericAlias fixes
18e7ff5
@mattip @devdanzin
can't -> cannot on PyPy
279a8f9
@mattip @devdanzin
tweak exception raised when star_args fails, deal with variations in …
565b2fb 
…error messages
@mattip @devdanzin
skip setstate/getstate tests in multibytecodec
2fc675a
@mattip @devdanzin
skip frozen __hello__ test
40ed48d
@mattip @devdanzin
properly create c-extension _ctypes_test
29d34f1
@mattip @devdanzin
skip some ctype details
35e9fb7
@mattip @devdanzin
skip newly added func.__builtins__ as an implementation detail, docum…
8b54842 
…ent the difference
cfbolz and others added 24 commits May 24, 2024 04:58
@cfbolz @devdanzin
pypy#3932: backport GH-91790 to 3.10: make sure that PyCode_NewEmpty …
5df3473 
…returns a code

object that:
- raises an AssertionError when called
- produces the correct line number when doing so
@cfbolz @devdanzin
pypy#3932: to be on the safe side, write an explicit test about how C…
e7e02bb 
…ython does

error positions now
@cfbolz @devdanzin
pypy#3932 fix translation
fc03f94
@cfbolz @devdanzin
test and fix segfault discovered by the cython tests
8fa6199
@mattip @devdanzin
resync space.pow() for merge
2fadb26
@mattip @devdanzin
fix for inplace_pow
4305d97
@mattip @devdanzin
fix error message and test
27f11a6
@devdanzin
update to cpython 3.10.12
9ac927f
@devdanzin
update python version to 3.10.12
136dd46
@devdanzin
add name mapping for newer hash names
abc09fe
@mattip @devdanzin
fix bad merge
dcaa273
@mattip @devdanzin
fix, test locking in HMAC update (issue 3962)
2ceeb48
@cfbolz @devdanzin
mark normalization of encoding as immutable
7be91ba
@mattip @devdanzin
add missing slot macro Py_am_send (issue 3990)
5fdd29d
@mattip @devdanzin
update to v3.10.13
d116487
@mattip @devdanzin
update python version to 3.10.13
56ff165
@cfbolz @devdanzin
pypy#4032 LIST_EXTEND bytecode should just let all exceptions through…
41eed47 
… if the second

argument is iterable
@mattip @devdanzin
more merge fixes
0e094b8
@cfbolz @devdanzin
pypy#4036: pattern matching classes now use the full isinstance machi…
356aae2 
…nery, calling

__instancecheck__ too.
@mattip @devdanzin
more merge fixes
67390f8
@mattip @devdanzin
test, implement window API functions PyErr_SetFromWindowsErrWithFilen…
cc891c5 
…ame, PyErr_SetExcFromWindowsErrWithFilenameObject, PyErr_SetExcFromWindowsErrWithFilenameObjects (issue pypy#4035)
@mattip @devdanzin
fix translation on windows
4475100
@devdanzin
Add some missing sqlite3 symbols.
63e57e4
@devdanzin
Add some missing sqlite3 defines.
2f98b19
@devdanzin devdanzin changed the base branch from branches/py3.10 to branches/py3.9 May 24, 2024 08:18
@devdanzin
Copy link
Contributor Author

While I'm sure there's a way to re-target a PR to a new branch and rebase things, I'm failing at it. Will create a new one instead.

@devdanzin devdanzin closed this May 24, 2024
@mattip
Copy link
Member

mattip commented May 24, 2024

I do this kind of thing with git cherry-pick <commit> accross branches. You need to know which commits you did, then you can

git checkout py3.9
git pull
git checkout -b sqlite_symbols2
git cherry-pick <commit1>
git cherry-pick <commit2>
...
git push devdanzin

Then when you create the new PR you will only have the commits you want

@devdanzin devdanzin deleted the sqlite_symbols branch May 27, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devdanzin @mattip @cfbolz @isidentical